Opened 8 years ago
Closed 8 years ago
#3556 closed bug (fixed)
Draggable connectToSortable revert bug
| Reported by: | Flat Stanley | Owned by: | paul |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.7 |
| Component: | ui.draggable | Version: | 1.5.2 |
| Keywords: | connectToSortable revert | Cc: | |
| Blocked by: | Blocking: |
Description
When we set a revert: "invalid" to a draggable connected to a sortable, we would expect that dropping the draggable onto the sortable would be considered a "valid" drop. However, I find that the item reverts to its original position and then adds itself to the sortable list. So, it seems to be considered an "invalid" drop.
Change History (6)
comment:1 in reply to: ↑ description Changed 8 years ago by Marc Diethelm
comment:2 Changed 8 years ago by scottgonzalez
- Milestone changed from TBD to 1.6
- Resolution set to fixed
- Status changed from new to closed
Closing as fixed based on Marc's comment. Feel free to re-open this ticket if you continue to have problems with 1.6rc3+.
comment:3 Changed 8 years ago by Marc Diethelm
tested with 1.6rc4
The bug is still valid unfortunately. Maybe I can make a testcase tomorrow.
- Trac tells me I don't have permission to reopen. *sigh*
comment:4 Changed 8 years ago by rdworth
- Resolution fixed deleted
- Status changed from closed to reopened
comment:5 Changed 8 years ago by alan.castro
I'm attaching a patch that fixes this problem. I used the trunk version.
comment:6 Changed 8 years ago by paul
- Resolution set to fixed
- Status changed from reopened to closed
Was a bit more difficult to fix than the provided patch (the provided patch simply kills revert if connectToSortable is used). Fixed in r1557.
I found this to be fixed in trunk. Should be released in 1.6rc3. (I'm not on the team.)