Opened 9 years ago
Closed 9 years ago
#3556 closed bug (fixed)
Draggable connectToSortable revert bug
| Reported by: | Flat Stanley | Owned by: | paul |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.7 |
| Component: | ui.draggable | Version: | 1.5.2 |
| Keywords: | connectToSortable revert | Cc: | |
| Blocked by: | Blocking: |
Description
When we set a revert: "invalid" to a draggable connected to a sortable, we would expect that dropping the draggable onto the sortable would be considered a "valid" drop. However, I find that the item reverts to its original position and then adds itself to the sortable list. So, it seems to be considered an "invalid" drop.
Attachments (1)
Change History (7)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
| Milestone: | TBD → 1.6 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Closing as fixed based on Marc's comment. Feel free to re-open this ticket if you continue to have problems with 1.6rc3+.
comment:3 Changed 9 years ago by
tested with 1.6rc4
The bug is still valid unfortunately. Maybe I can make a testcase tomorrow.
- Trac tells me I don't have permission to reopen. *sigh*
comment:4 Changed 9 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:5 Changed 9 years ago by
I'm attaching a patch that fixes this problem. I used the trunk version.
Changed 9 years ago by
| Attachment: | sortable-3556.patch added |
|---|
patch that fixes revert problem with draggable that has connectToSortable option.
comment:6 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Was a bit more difficult to fix than the provided patch (the provided patch simply kills revert if connectToSortable is used). Fixed in r1557.
I found this to be fixed in trunk. Should be released in 1.6rc3. (I'm not on the team.)