Opened 7 years ago

Closed 7 years ago

#3648 closed enhancement (fixed)

Dialog: Update markup to new UI CSS Framework specs

Reported by: jzaefferer Owned by: scottgonzalez
Priority: blocker Milestone: 1.7
Component: ui.dialog Version: 1.6rc2
Keywords: Cc:
Blocked by: Blocking:

Description

The new jQuery UI CSS Framework was finalized and will be in 1.6rc3. The appropriate changes need to made to the plugin. For markup reference, see

http://jquery-ui.googlecode.com/svn/trunk/tests/static/dialog.html

Attachments (2)

dialog-container-r1174.patch (4.9 KB) - added by scottgonzalez 7 years ago.
Removal of container div and autoResize option
dialog-container-r1175.patch (5.9 KB) - added by scottgonzalez 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by scottgonzalez

  • Owner set to scott.gonzalez
  • Status changed from new to accepted

Mostly fixed in r1091. The .ui-dialog-container still needs to be removed to match the static markup. I didn't remove this yet because I'm not sure what the implications are.

comment:2 Changed 7 years ago by jzaefferer

The 1.6 release will break compability, so you should just remove that class to get things cleaned up.

Changed 7 years ago by scottgonzalez

Removal of container div and autoResize option

comment:3 Changed 7 years ago by scottgonzalez

Also currently missing the se resizable icon.

comment:4 Changed 7 years ago by scottgonzalez

The current patch for removing the container div doesn't handle buttons properly.

comment:5 Changed 7 years ago by scottgonzalez

The new patch fixes the problem with the buttonpnae positioning.

Changed 7 years ago by scottgonzalez

comment:6 Changed 7 years ago by scottgonzalez

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed in r1177.

Note: See TracTickets for help on using tickets.