Skip to main content

Search and Top Navigation

#3713 closed bug (fixed)

Opened December 30, 2008 07:26PM UTC

Closed December 31, 2008 01:13AM UTC

height option for dialog

Reported by: filamentgroup Owned by:
Priority: critical Milestone: 1.7
Component: ui.dialog Version: 1.6rc2
Keywords: Cc:
Blocked by: Blocking:

In general, the dialog seems to open to a set height of ~250px by default which is somewhat unexpected and is too tall for an average confirmation/message but too small for a form. It would be more useful if it auto fit the content length and had a maxHeight default set to something reasonable like 400px so it would fit on an average 1024x768 screen without scrolling. It's a pain/dangerous to have to set an explicit height every time.

This should behave like a normal block element that expands to the content as much as possible. I get worried about setting a fixed pixel height because font sizes and content lengths could very and you really want to avoid scrollbars on dialogs as much as possible.

Attachments (0)
Change History (2)

Changed December 30, 2008 10:40PM UTC by scottgonzalez comment:1

Would this be satisfied just by defaulting the height option to auto?

Changed December 31, 2008 01:13AM UTC by scottgonzalez comment:2

resolution: → fixed
status: newclosed

Fixed in r1380. Set default height to auto and default minHeight to 150.