Changes between Initial Version and Version 1 of Ticket #3749, comment 7


Ignore:
Timestamp:
Dec 16, 2011, 12:52:53 PM (8 years ago)
Author:
jdmarshall
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3749, comment 7

    initial v1  
    11I've spent a lot more time poking around the code now and I have another request.
    22
    3 It turns out that most of the time spent in sortable() relates to calculating the size of the 'items'.  That's a pretty expensive proposition for large sortables, especially if all of the sortables are of uniform size.
     3Each sortable has a full table of every other item in its connectWith containers.  Probably the containers should do their own thing.  This starts to get pretty bad even with only 3 containers, because you get 9 entries for each item.  So that's probably priority 1, and could be fixed as part of a breadth-first search solution (ie, find the containers I'm intersecting with, then ask them about their items, rather than keeping my own cache).
     4
     5Beyond that, it turns out that most of the time spent in sortable() relates to calculating the size of the 'items'.  That's a pretty expensive proposition for large sortables, especially if all of the sortables are of uniform size.
    46
    57So for each element you look up half to a dozen CSS rules, then repeat it for the next element.  It would be nice to either be able to provide hints, or for the sizing code to notice that most of the sorted items have identical CSS and look it up once.