accordion no longer supports dl

[wichert]

In 1.6b it was possible to use a dl list for the accordion if you passed in a headers: "dt" option. This no longer works with rc4.

This is very inconvenient: a dl is the most natural (and semantically correct often) markup style you can use for an accordion and much simpler to write.

[Jörn Zaefferer]

This is a regression caused by the workaround to fix animations. In lack of a better solution for the jumpy animations we may need to accept this and defer the fix to a later release.

[Scott González]

We need to try to find a different workaround to remove the regression. We should have a working prototype of how to do this without the extra div by looking at animations in jQuery core, since they animate padding and margin now.

[Scott González]

I've attached a patch to remove the content wrapper div and animate the padding and margin of the content element. This should make it possible to use dl's again. This will also require the CSS to be updated (available in /tests/static/accordion/default_nowrappers.html). There's a 1px shift during animation that I can't track down. I'm not sure if the destroy method will also need to be updated. The demos may need to be updated as well.

[Jörn Zaefferer]

Visual test for dl-accordion

[Jörn Zaefferer]

Removed code for groups

[Jörn Zaefferer]

complete patch with modified demos/accordion/default.html, tests/visual/dl.html and accordion patch for fixing container height for autoHeight accordions

[Scott González]

patch to be applied with Jörn's latest patch - improves the jump and removes the container height setting

[Scott González]

The jump improvement patch makes the animation completely smooth in Firefox. There is still a jump in other browsers, and I have to specifically exclude border animations in IE.

[Scott González]

Fixed in r1878.

[etiger13]

​http://dev.jqueryui.com/changeset/1878/trunk/ui/ui.accordion.js

Why was the ui-accordion-group class functionality removed? Doesn't look like it was/would cause a problem. This is on line 36 and 106. It was in the code for awhile and if anyone created styles based on that update, it breaks. I propose those two lines be added back in since it shouldn't affect anything but leaving them out will affect some sites.