Search and Top Navigation
#3901 closed bug (fixed)
Opened January 21, 2009 06:17PM UTC
Closed January 29, 2009 04:13AM UTC
Dialog + themeroller breaks in IE6 due to negative minHeight
| Reported by: | cjwilks | Owned by: | scottgonzalez |
|---|---|---|---|
| Priority: | critical | Milestone: | 1.7 |
| Component: | ui.dialog | Version: | 1.6rc5 |
| Keywords: | Cc: | mctenshi@gmail.com | |
| Blocked by: | Blocking: |
Description
Description courtesy Goonoo Kim. References:
- http://groups.google.com/group/jquery-ui/browse_thread/thread/ea5e64ff8b073e2c
- http://groups.google.com/group/jquery-ui/browse_thread/thread/d89e7ddf5310ab41
Using JQuery UI 1.6rc5 and jQuery 1.3: The following example doesn't work in IE6.
#!xml
<!-- height of content is over than 150 -->
<div id="dialog">
<p>blah blah</p>
<p>blah blah</p>
<p>blah blah</p>
<p>blah blah</p>
<p>blah blah</p>
<p>blah blah</p>
<p>blah blah</p>
<p>blah blah</p>
<p>blah blah</p>
</div>
<script type="text/javascript">
$("#dialog").dialog({minHeight: 150}); // minHeight as default
</script>
In above case, 454 Line of jQuery UI Dialog 1.6rc5 got error on IE6.
#!java
this.element
.css({
//***IE breaks when this is a negative number***//
minHeight: options.minHeight - nonContentHeight,
height: options.height == 'auto'
? 'auto'
: options.height - nonContentHeight
});
Attachments (0)
Change History (4)
Changed January 21, 2009 06:20PM UTC by comment:1
Changed January 28, 2009 05:52AM UTC by comment:2
Just commented on this in #3930 as well; recommend that
minHeight: options.minHeight - nonContentHeight,
be changed to
minHeight: Math.max(options.minHeight - nonContentHeight,0),
to keep minHeight non-negative
Changed January 29, 2009 04:10AM UTC by comment:3
| owner: | → scott.gonzalez |
|---|---|
| priority: | major → critical |
| status: | new → accepted |
Changed January 29, 2009 04:13AM UTC by comment:4
| resolution: | → fixed |
|---|---|
| status: | accepted → closed |
Fixed in r1845. Thanks.
The workaround for now is to manually set minHeight to something large enough...
#!java $("...").dialog({ minHeight: 500 });