Opened 14 years ago
Closed 14 years ago
#3901 closed bug (fixed)
Dialog + themeroller breaks in IE6 due to negative minHeight
Reported by: | cjwilks | Owned by: | Scott González |
---|---|---|---|
Priority: | critical | Milestone: | 1.7 |
Component: | ui.dialog | Version: | 1.6rc5 |
Keywords: | Cc: | [email protected]… | |
Blocked by: | Blocking: |
Description
Description courtesy Goonoo Kim. References:
- http://groups.google.com/group/jquery-ui/browse_thread/thread/ea5e64ff8b073e2c
- http://groups.google.com/group/jquery-ui/browse_thread/thread/d89e7ddf5310ab41
Using JQuery UI 1.6rc5 and jQuery 1.3: The following example doesn't work in IE6.
<!-- height of content is over than 150 --> <div id="dialog"> <p>blah blah</p> <p>blah blah</p> <p>blah blah</p> <p>blah blah</p> <p>blah blah</p> <p>blah blah</p> <p>blah blah</p> <p>blah blah</p> <p>blah blah</p> </div> <script type="text/javascript"> $("#dialog").dialog({minHeight: 150}); // minHeight as default </script>
In above case, 454 Line of jQuery UI Dialog 1.6rc5 got error on IE6.
this.element .css({ //***IE breaks when this is a negative number***// minHeight: options.minHeight - nonContentHeight, height: options.height == 'auto' ? 'auto' : options.height - nonContentHeight });
Change History (4)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
Just commented on this in #3930 as well; recommend that
minHeight: options.minHeight - nonContentHeight,
be changed to
minHeight: Math.max(options.minHeight - nonContentHeight,0),
to keep minHeight non-negative
comment:3 Changed 14 years ago by
Owner: | set to scott.gonzalez |
---|---|
Priority: | major → critical |
Status: | new → accepted |
comment:4 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
Fixed in r1845. Thanks.
Note: See
TracTickets for help on using
tickets.
The workaround for now is to manually set minHeight to something large enough...