Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#3938 closed bug (fixed)

Add borderColor-step-method

Reported by: trixta Owned by:
Priority: major Milestone: 1.8
Component: ui.effects.core Version: 1.6rc5
Keywords: Cc:
Blocked by: Blocking:

Description

If you are using the animateClass-method IE tries to use the shorthand property 'borderColor', instead of borderBottomColor, borderTopColor etc..

To get this work, i added the following lines to the effects.core:

var colorPropterties = ['backgroundColor', 'borderBottomColor', 'borderLeftColor', ...];

if (!$.browser.msie) {

colorPropterties.push('borderColor');

}

create color-step functions:

$.each(colorPropterties, ...

modified version of effects.core (bugfixes, enhancements and new features): http://www.protofunc.com/scripts/jquery/classanimation/

Change History (5)

comment:1 Changed 7 years ago by paul

  • Milestone changed from TBD to 1.next
  • Priority changed from minor to major

comment:2 Changed 7 years ago by trixta

I think, I was wrong on this. The borderColor-Property should be filtered out by the animateClass-Method, instead. If a borderColor (for example: borderLeftColor) changes animateclass trys to animate both bordercolor + borderLeftColor.

comment:3 Changed 7 years ago by bman654

Please do not just filter away "borderColor" - I encountered this exact bug yesterday. If you are concerned about possibly animating both borderColor and borderLeftColor, then occurrences of borderColor should be replaced with borderLeftColor, borderTopColor, borderBottomColor, borderRightColor and only those that are already in the property list should thrown away.

comment:4 Changed 7 years ago by scottgonzalez

  • Milestone changed from 1.next to 1.8
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3411 by adding borderColor to the list of supported properties. I can't see any negative side effects to this, other than an extremely minor performance hit.

comment:5 Changed 7 years ago by scottgonzalez

Decided to go with trixta's suggestion and filter out borderColor. Whenever borderColor needs to be animated it always shows up as the individual properties. I'm now filtering all shorthand styles.

Note: See TracTickets for help on using tickets.