Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#3938 closed bug (fixed)

Add borderColor-step-method

Reported by: trixta Owned by:
Priority: major Milestone: 1.8
Component: ui.effects.core Version: 1.6rc5
Keywords: Cc:
Blocked by: Blocking:


If you are using the animateClass-method IE tries to use the shorthand property 'borderColor', instead of borderBottomColor, borderTopColor etc..

To get this work, i added the following lines to the effects.core:

var colorPropterties = ['backgroundColor', 'borderBottomColor', 'borderLeftColor', ...];

if (!$.browser.msie) {



create color-step functions:

$.each(colorPropterties, ...

modified version of effects.core (bugfixes, enhancements and new features):

Attachments (2)

test.html (726 bytes) - added by bman654 12 years ago.
Shows the problem.
borderColorFix.patch (1.4 KB) - added by bman654 12 years ago.
This patch resolves the problem

Download all attachments as: .zip

Change History (7)

comment:1 Changed 13 years ago by paul

Priority: minormajor

comment:2 Changed 12 years ago by trixta

I think, I was wrong on this. The borderColor-Property should be filtered out by the animateClass-Method, instead. If a borderColor (for example: borderLeftColor) changes animateclass trys to animate both bordercolor + borderLeftColor.

comment:3 Changed 12 years ago by bman654

Please do not just filter away "borderColor" - I encountered this exact bug yesterday. If you are concerned about possibly animating both borderColor and borderLeftColor, then occurrences of borderColor should be replaced with borderLeftColor, borderTopColor, borderBottomColor, borderRightColor and only those that are already in the property list should thrown away.

Changed 12 years ago by bman654

Attachment: test.html added

Shows the problem.

Changed 12 years ago by bman654

Attachment: borderColorFix.patch added

This patch resolves the problem

comment:4 Changed 12 years ago by Scott González

Milestone: 1.next1.8
Resolution: fixed
Status: newclosed

Fixed in r3411 by adding borderColor to the list of supported properties. I can't see any negative side effects to this, other than an extremely minor performance hit.

comment:5 Changed 12 years ago by Scott González

Decided to go with trixta's suggestion and filter out borderColor. Whenever borderColor needs to be animated it always shows up as the individual properties. I'm now filtering all shorthand styles.

Note: See TracTickets for help on using tickets.