Opened 11 years ago

Closed 10 years ago

#3992 closed bug (wontfix)

Ensure that no plugins modify the options hash

Reported by: Scott González Owned by:
Priority: blocker Milestone: 1.8
Component: [meta] ui.dev Version: 1.6rc5
Keywords: Cc:
Blocked by: Blocking:

Description

Review all plugins and create tickets for any plugins that modify the options hash in any way, other than explicitly setting an option to a value provided by the user.

Change History (5)

comment:1 Changed 10 years ago by Scott González

Milestone: 1.next1.8

comment:2 Changed 10 years ago by Jörn Zaefferer

ui.draggable.js modifies options.helper in the stop method (line 477 on r2516), as well as creating options._helper and modifying options.helper in the drag method (line 521 and 522 on r2516). Also options.revert is (temporirly) modified in the stop method (line 555).

comment:3 Changed 10 years ago by Jörn Zaefferer

Summary: Ensure that no plugins modify the options hasho

ui.resizable.js modifies options.zIndex, incrementing by one whenever the option is used, even with an explicit comment TODO to not modify the option. options.alsoResize is modified as well.

comment:4 Changed 10 years ago by Jörn Zaefferer

Summary: oEnsure that no plugins modify the options hash

ui.slider.js modifies options.values when initially undefined.

ui.sortable.js modifies options.placeholder when initially undefined.

ui.tabs.js modifies options.disabled (an array to store which tabs are disable), as well as options.selected (index of the selected tab)

comment:5 Changed 10 years ago by Scott González

Resolution: wontfix
Status: newclosed

Closing as we've changed our standard to require changing the options hash to represent the state of the plugin.

Note: See TracTickets for help on using tickets.