Search and Top Navigation
#3992 closed bug (wontfix)
Opened January 30, 2009 03:13AM UTC
Closed January 07, 2010 03:59AM UTC
Ensure that no plugins modify the options hash
| Reported by: | scottgonzalez | Owned by: | |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.8 |
| Component: | [meta] ui.dev | Version: | 1.6rc5 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Review all plugins and create tickets for any plugins that modify the options hash in any way, other than explicitly setting an option to a value provided by the user.
Attachments (0)
Change History (5)
Changed March 30, 2009 01:32AM UTC by comment:1
| milestone: | 1.next → 1.8 |
|---|
Changed May 11, 2009 01:26PM UTC by comment:2
ui.draggable.js modifies options.helper in the stop method (line 477 on r2516), as well as creating options._helper and modifying options.helper in the drag method (line 521 and 522 on r2516). Also options.revert is (temporirly) modified in the stop method (line 555).
Changed May 11, 2009 01:37PM UTC by comment:3
| summary: | Ensure that no plugins modify the options hash → o |
|---|
ui.resizable.js modifies options.zIndex, incrementing by one whenever the option is used, even with an explicit comment TODO to not modify the option.
options.alsoResize is modified as well.
Changed May 11, 2009 01:42PM UTC by comment:4
| summary: | o → Ensure that no plugins modify the options hash |
|---|
ui.slider.js modifies options.values when initially undefined.
ui.sortable.js modifies options.placeholder when initially undefined.
ui.tabs.js modifies options.disabled (an array to store which tabs are disable), as well as options.selected (index of the selected tab)
Changed January 07, 2010 03:59AM UTC by comment:5
| resolution: | → wontfix |
|---|---|
| status: | new → closed |
Closing as we've changed our standard to require changing the options hash to represent the state of the plugin.