Opened 11 years ago

Closed 11 years ago

#4047 closed enhancement (duplicate)

The dialog buttons should have ids

Reported by: abtrapp Owned by:
Priority: major Milestone: 1.8
Component: ui.dialog Version: 1.6rc6
Keywords: button id Cc:
Blocked by: Blocking:

Description

It is almost impossible to test jQuery dialogs with most of the browser test tools, because dialog buttons can't have IDs. Even automatically generated IDs (with a numbering) would help.

The decision is: don't use jQuery dialogs or don't test your software.

I think that testing is important ;)

Change History (4)

comment:1 Changed 11 years ago by rdworth

Milestone: 1.71.8

comment:2 Changed 11 years ago by Scott González

How are you going to reference buttons by id if the ids are auto-generated with an unpredictable number? Are you not able to reference buttons by position, e.g., .ui-dialog-buttonpane button:first?

comment:3 Changed 11 years ago by andrew_

I'm in agreement with Scott G. I've used exactly that method to examine and test dialog functionality. I propose the priority be changed to minor.

comment:4 Changed 11 years ago by Scott González

Resolution: duplicate
Status: newclosed

I moved this suggestion into #4344 which covers the overall redesign of button flexibility.

Note: See TracTickets for help on using tickets.