#4047 closed enhancement (duplicate)

Opened February 02, 2009 09:17PM UTC

Closed April 18, 2009 02:45AM UTC

The dialog buttons should have ids

Reported by: abtrapp Owned by:
Priority: major Milestone: 1.8
Component: ui.dialog Version: 1.6rc6
Keywords: button id Cc:
Blocked by: Blocking:
Description

It is almost impossible to test jQuery dialogs with most of the browser test tools, because dialog buttons can't have IDs. Even automatically generated IDs (with a numbering) would help.

The decision is: don't use jQuery dialogs or don't test your software.

I think that testing is important ;)

Attachments (0)
Change History (4)

Changed March 08, 2009 02:39PM UTC by rdworth comment:1

milestone: 1.7 → 1.8

Changed March 16, 2009 12:39AM UTC by scottgonzalez comment:2

How are you going to reference buttons by id if the ids are auto-generated with an unpredictable number? Are you not able to reference buttons by position, e.g., .ui-dialog-buttonpane button:first?

Changed April 12, 2009 10:32PM UTC by andrew_ comment:3

I'm in agreement with Scott G. I've used exactly that method to examine and test dialog functionality. I propose the priority be changed to minor.

Changed April 18, 2009 02:45AM UTC by scottgonzalez comment:4

resolution: → duplicate
status: new → closed

I moved this suggestion into #4344 which covers the overall redesign of button flexibility.