Opened 14 years ago
Closed 14 years ago
#4182 closed bug (fixed)
slider min/max classes aren't being added to range div
Reported by: | scottjehl | Owned by: | rdworth |
---|---|---|---|
Priority: | critical | Milestone: | 1.7 |
Component: | ui.slider | Version: | 1.6rc6 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description (last modified by )
the ui-slider-range-max class is not being added to the ui-slider-range div. Same for the ui-slider-range-min class. Instead, the styles are being set inline. Only the styles that need computing based on value should be set inline.
The CSS is already designed to support these classes.
Change History (5)
comment:1 Changed 14 years ago by
Owner: | set to rdworth |
---|---|
Status: | new → assigned |
comment:2 Changed 14 years ago by
Description: | modified (diff) |
---|---|
Priority: | major → critical |
comment:3 Changed 14 years ago by
Note that our static demo pages for min and max have this class and inline css properly applied. trunk/tests/static/slider/slider_horizontal_range_max.html trunk/tests/static/slider/slider_horizontal_range_min.html
same for vertical
comment:4 Changed 14 years ago by
Milestone: | TBD → 1.6 |
---|
Note: See
TracTickets for help on using
tickets.
This is actually the cause of the Opera bug too. From my testing, it appears the change discussed a while back where we'd remove the unnecessary value in min and max has not been implemented.
For example, in a horizontal slider max range, the left value should never be set inline. Only a width - nothing else. The css already has right: 0.
This should be true of all slider min/max ranges, respectively. I closed bug 3850 and assigned this to rdworth.