Opened 14 years ago
Closed 14 years ago
#4436 closed bug (fixed)
Accordion fillSpace not accounting for header margins
Reported by: | GreyCells | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 1.8 |
Component: | ui.accordion | Version: | 1.7.1 |
Keywords: | outerHeight margin | Cc: | |
Blocked by: | Blocking: |
Description
This is similar to #4267, but just one specific problem with (in my use cases, at least) a very trivial solution.
If the accordion headers have a non-zero margin, fillSpace consistently calculates the incorrect height for the content div.
In r2307, changing line 182 from: maxHeight -= $(this).outerHeight();
to: maxHeight -= $(this).outerHeight(true);
to account for the margins, appears to resolve this with no ill effects elsewhere.
Change History (2)
comment:1 Changed 14 years ago by
Milestone: | 1.7.2 → 1.8 |
---|
comment:2 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Fixed in r3046.