Skip to main content

Search and Top Navigation

#4436 closed bug (fixed)

Opened April 05, 2009 06:49PM UTC

Closed August 11, 2009 06:46PM UTC

Accordion fillSpace not accounting for header margins

Reported by: GreyCells Owned by:
Priority: major Milestone: 1.8
Component: ui.accordion Version: 1.7.1
Keywords: outerHeight margin Cc:
Blocked by: Blocking:

This is similar to #4267, but just one specific problem with (in my use cases, at least) a very trivial solution.

If the accordion headers have a non-zero margin, fillSpace consistently calculates the incorrect height for the content div.

In r2307, changing line 182 from:

maxHeight -= $(this).outerHeight();
maxHeight -= $(this).outerHeight(true);
to account for the margins, appears to resolve this with no ill effects elsewhere.

Attachments (0)
Change History (2)

Changed May 07, 2009 01:28PM UTC by jzaefferer comment:1


Changed August 11, 2009 06:46PM UTC by jzaefferer comment:2

resolution: → fixed
status: newclosed

Fixed in r3046.