Skip to main content

Search and Top Navigation

#4488 closed bug (fixed)

Opened April 21, 2009 01:21PM UTC

Closed September 02, 2010 03:52PM UTC

Last modified November 19, 2010 06:26PM UTC

:focusable and :tabbable are broken with jQuery 1.3.2

Reported by: scottgonzalez Owned by:
Priority: major Milestone: 1.8.5
Component: ui.core Version: 1.7.1
Keywords: Cc:
Blocked by: Blocking:

The change to :hidden and :visible have broken the :focusable and :tabbable selectors.

Attachments (0)
Change History (12)

Changed May 08, 2009 11:17AM UTC by jzaefferer comment:1

I've looked at the code. The interesting part seems to be this check:

// the element and all of its ancestors must be visible
// the browser may report that the area is hidden
&& !$(element)['area' == nodeName ? 'parents' : 'closest'](':hidden').length;

Seems like we could just check the visibility of the element itself instead of checking ancestors. So this should do the trick:

&& $(element).is(":visible");

Fixes 7 of 17 failing tests, thats something...

Changed July 07, 2009 05:06PM UTC by d3r1v3d comment:2

+1 to Joern's suggested patch - I definitely agree that checking if the element is visible makes more sense.

Concerning the 'visible, enabled elements' tests failing for the 'area with href' case, I've noticed that these <area> elements consistently have an offsetWidth and offsetHeight of 0. I believe this is because the test map doesn't have any <img usemap=""/> relationships attached to it, so all of its internal <area>s are essentially hidden. jQuery 1.3.2 checks for a positive offsetWidth or offsetHeight in its implementation of the ':visible' selector and so this is what causes that subtest to fail.

However, the <map> parent should still have a valid width/height, and the following tweak to Joern's suggest patch causes all of the 'visible, enabled elements' tests to pass 100% in Firefox 2/3:

&& ('area' == nodeName
    ? $(element).closest('map').is(':visible')
    : $(element).is(':visible'));

The problem is that the same is not true for either Chrome or IE 7. They both consistently report that the <map> and all nested <area>s have an offsetWidth/offsetHeight of 0, causing the is(':visible') check to report false every time.

Changed August 06, 2009 05:24PM UTC by jzaefferer comment:3

So :focusable is actually used only by :tabbable, which in turned is used only by Dialog. Seems like we imagined more of a usecase where actually only one exist: focus the first element in a dialog.

Which reminds me of the code in my validation plugin, which basically just gets the first invalid input (not interesting here), then does .filter(":visible").focus();

The call is wrapped in a try-catch-swallow block for some IE-edgecases.

Changed August 06, 2009 05:30PM UTC by jzaefferer comment:4

priority: criticalmajor

Changed May 23, 2010 03:25PM UTC by AzaToth comment:5

can someone please explain this bug in more detail, and where this applies? (i.e. what change?)

Changed July 22, 2010 02:20AM UTC by scottgonzalez comment:6

Mostly fixed in 3f070bd.

Changed July 23, 2010 01:05AM UTC by scottgonzalez comment:7

Area elements are fixed in fe13fba.

Changed July 30, 2010 10:09AM UTC by jzaefferer comment:8

What's left?

Changed July 30, 2010 04:26PM UTC by scottgonzalez comment:9

The object tests still fail in IE. I cant seem to come up with a test that passes in all browsers at the same time.

Changed September 02, 2010 03:52PM UTC by scottgonzalez comment:10

resolution: → fixed
status: newclosed

Objects fixed in 0ab54d8.

Changed September 10, 2010 05:25PM UTC by scottgonzalez comment:11


Changed November 19, 2010 06:26PM UTC by Scott González comment:12

Core tests: Fixed object element for focusable/tabbable tests. Fixes #4488 - :focusable and :tabbable are broken with jQuery 1.3.2.

Changeset: 0ab54d87dc521b73819a3ac480f7aa94365e52e2