Opened 11 years ago

Closed 9 years ago

#4493 closed bug (fixed)

Out of Memory using Dialog with fade effect

Reported by: cupdike Owned by:
Priority: minor Milestone: 1.8
Component: ui.dialog Version: 1.7.1
Keywords: dialog effects memory Cc:
Blocked by: Blocking:

Description

Using JQuery 1.3.2 and UI 1.7.1, with a simple dialog demo with FadeOut effect, I get "Out of memory at line: 1280" in IE and similar "too much recursion" errors in FireFox (starts with line 26 of jquery-1.3.2.js). It's repeatable. All I have to do click the "Show the Dialog" link, close the dialog, and then click it again.

See also: ​http://groups.google.com/group/jquery-ui/browse_thread/thread/bae3c9a93c563c1e/f54cbd06d63aa511#f54cbd06d63aa511

Here the page (put this in the development-bundle\demos\dialog directory): 

<!DOCTYPE html><html><head>

    <link type="text/css" href="../../themes/base/ui.all.css"
rel="stylesheet" />

        <script type="text/javascript" src="../../jquery-1.3.2.js"></script>
        <script type="text/javascript" src="../../ui/ui.core.js"></script>
        <script type="text/javascript" src="../../ui/ui.dialog.js"></script>

  <script type="text/javascript">
function showDialog(){
   $("#divId").dialog("open");
   $("#modalIframeId").attr("src","http://www.google.com");
   return false;

}

$(document).ready(function() {
   $("#divId").dialog({
                show: {effect: "fold", duration: 500},
                autoOpen: false,
                modal: true,
                height: 500,
                width: 500
        });
});

  </script>
</head>
<body style="font-size:62.5%;">

<a href="" onclick="return showDialog()">Show the Dialog</a>

<div id="divId" title="Dialog Title">
        <iframe id="modalIframeId" width="100%" height="100%"
        marginWidth="0" marginHeight="0" frameBorder="0" scrolling="auto"
        title="Dialog Title">Your browser does not support framesr</iframe>
</div>

</body>
</html>

Change History (3)

comment:1 Changed 11 years ago by Jörn Zaefferer

Milestone: TBD → 1.7.2

comment:2 Changed 11 years ago by Jörn Zaefferer

Milestone: 1.7.2 → 1.8

comment:3 Changed 9 years ago by Scott González

Milestone: 1.9 → 1.8
Resolution: → fixed
Status: new → closed

I think this was fixed a while ago, then broke again in 1.8.5 (see #6078) and is now fixed again in master. I'm going to close as fixed in 1.8 since it seems to work even that far back.

Note: See TracTickets for help on using tickets.