Opened 14 years ago

Closed 13 years ago

#4501 closed enhancement (fixed)

Tabs should work with ordered lists (<ol>) in addition to unordered (<ul>)

Reported by: BenBlank Owned by:
Priority: minor Milestone: 1.8
Component: ui.tabs Version: 1.7.1
Keywords: tabs, ol, ordered, list Cc:
Blocked by: Blocking:


Currently, the tabs component will only read "tabbing" links from unordered lists. As ordered lists use identical structure, this seems like an unnecessary restriction.

Use case: I am currently building a tabbed interface which represents a multi-step application process. The steps (and tabs) are prominently displayed as "1. Getting Started", "2. Personal Info", etc., and the tabbing links have accelerator keys of 1, 2, etc. Clearly, the tabs semantically represent an ordered list, but using one prevents the use of the tabs component.

Find attached a simple patch against [source:/trunk/ui/[email protected] ui.tabs.js] which will cause the tabs component to use the first list in the target element, regardless of whether it is ordered or unordered.

Attachments (1)

[email protected] (460 bytes) - added by BenBlank 14 years ago.

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by BenBlank

Attachment: [email protected] added

comment:1 Changed 14 years ago by Jörn Zaefferer

Milestone: TBD1.8

Related to #4506.

comment:2 Changed 13 years ago by Scott González

Resolution: fixed
Status: newclosed

Fixed in r3421. The first descendant list found will be used now.

Note: See TracTickets for help on using tickets.