Skip to main content

Search and Top Navigation

#4511 closed bug (duplicate)

Opened May 04, 2009 02:49PM UTC

Closed May 11, 2009 12:33PM UTC

ESCAPE key close ALL opened modal dialogs

Reported by: xpg934 Owned by:
Priority: critical Milestone: 1.8
Component: ui.dialog Version: 1.7.1
Keywords: dialog escape modal Cc:
Blocked by: Blocking:

When I open two modal dialogs and press ESCAPE - all dialogs are closed. Not only topmost.

Attachments (1)
  • esc-bug.html (1.5 KB) - added by xpg934 May 04, 2009 02:50PM UTC.


Change History (3)

Changed May 07, 2009 01:34PM UTC by jzaefferer comment:1


Changed May 11, 2009 12:22PM UTC by jzaefferer comment:2

The dialog itself binds keydown event to itself for closing the dialog on ESC; in addition, the dialog overlay binds a keydown event to document, without filtering to close only the active dialog.

There doesn't seem be a trivial way to detect multiple modal dialogs. Maybe the right approach here is to prevent multiple modal dialogs in the first place. If we allow two, we allow an unlimited amount, sure to be causing performance issues, as each creates its own overlay.

Changed May 11, 2009 12:33PM UTC by scottgonzalez comment:3

resolution: → duplicate
status: newclosed

Duplicate of #3539.