Opened 8 years ago

Closed 7 years ago

Last modified 6 years ago

#4551 closed bug (notabug)

Sortable connectWith fails if item is floated

Reported by: dhlavaty Owned by:
Priority: critical Milestone:
Component: ui.sortable Version: 1.7.1
Keywords: float connectwith Cc:
Blocked by: Blocking:

Description

Connecting one sortable to another not working if item is floated (like in 'Display as Grid' demo).

It is working only in IE7. But not working in Firefox, Chrome, Opera.

Attachments (2)

connectWith-and-float-bug.html (1.4 KB) - added by dhlavaty 8 years ago.
connectWith and float bug works only in IE
patch.txt (564 bytes) - added by jlillywhite 8 years ago.
This seems to resolve the issue in Firefox and Chrome.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by dhlavaty

connectWith and float bug works only in IE

comment:1 Changed 8 years ago by rdworth

Milestone: 1.7.21.8
Priority: blockercritical

Changed 8 years ago by jlillywhite

Attachment: patch.txt added

This seems to resolve the issue in Firefox and Chrome.

comment:2 Changed 8 years ago by rdworth

Resolution: fixed
Status: newclosed

Fixed in r2882

comment:3 Changed 7 years ago by scribu

FYI: This caused some issues downstream:

http://core.trac.wordpress.org/ticket/16955

comment:4 Changed 7 years ago by rdworth

Milestone: 1.8
Resolution: fixed
Status: closedreopened

It turns out this test case was invalid. The sortable items had float:left but the sortable containers did not, giving them no height. The fix is a css one, set float:left on the sortable containers as well as the sortable items.

comment:5 Changed 7 years ago by rdworth

Reverted from master (1.9pre) in 54016b8

comment:6 Changed 7 years ago by rdworth

Resolution: invalid
Status: reopenedclosed

Reverted from 1-8-stable in c205fbc

comment:7 Changed 6 years ago by uacode

change: float: left to display: inline-block

Note: See TracTickets for help on using tickets.