Opened 10 years ago

Closed 10 years ago

#4590 closed bug (fixed)

Themeroller and Icon Filename Case

Reported by: nikolae Owned by:
Priority: blocker Milestone: 1.8
Component: [meta] ui.themeroller Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:

Description

I just recently updated my theme on themeroller, only to discover that most icons had vanished, with the exception of hover icons.

Upon inspection of the CSS, I realized that themeroller had converted the hex color code to lowercase in the icon filename, but not in the CSS file itself; it copied verbatim what was in text boxes. Apparently I had typed the color code in lowercase for the hover icons, but in uppercase for the rest. Oddly enough, it displayed correctly on the test page, only adding to the confusion.

A simple fix would be to apply a case-consistency rule across the board. Stick with either uppercase or lowercase and force it on all color codes wherever they're used.

I rated this as a fairly major bug, as themeroller is supposed to make CSS easy for those who aren't familiar with it. Many beginning users that experience an issue like this will just reach the conclusion that it doesn't work and move to something else.

Change History (5)

comment:1 Changed 10 years ago by Jörn Zaefferer

Component: ui.core[meta] ui.themeroller
Milestone: TBD1.8
Priority: majorcritical

comment:2 Changed 10 years ago by Jörn Zaefferer

Priority: criticalblocker

comment:3 Changed 10 years ago by scottjehl

I've updated app.js to convert the hex to lowercase in the validHex function. I'm not sure how to push this live anymore with everything on static - in fact, I'm not sure how to even test that it works beforehand!

I will follow through with server-side fix as well.

comment:4 Changed 10 years ago by scottjehl

Also updated parseVars.php with strtolower() wrapped around all incoming hex values.

comment:5 Changed 10 years ago by scottjehl

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.