Skip to main content

Search and Top Navigation

#4590 closed bug (fixed)

Opened June 09, 2009 09:49PM UTC

Closed February 10, 2010 04:51PM UTC

Themeroller and Icon Filename Case

Reported by: nikolae Owned by:
Priority: blocker Milestone: 1.8
Component: [meta] ui.themeroller Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:

I just recently updated my theme on themeroller, only to discover that most icons had vanished, with the exception of hover icons.

Upon inspection of the CSS, I realized that themeroller had converted the hex color code to lowercase in the icon filename, but not in the CSS file itself; it copied verbatim what was in text boxes. Apparently I had typed the color code in lowercase for the hover icons, but in uppercase for the rest. Oddly enough, it displayed correctly on the test page, only adding to the confusion.

A simple fix would be to apply a case-consistency rule across the board. Stick with either uppercase or lowercase and force it on all color codes wherever they're used.

I rated this as a fairly major bug, as themeroller is supposed to make CSS easy for those who aren't familiar with it. Many beginning users that experience an issue like this will just reach the conclusion that it doesn't work and move to something else.

Attachments (0)
Change History (5)

Changed June 10, 2009 09:35AM UTC by jzaefferer comment:1

component: ui.core[meta] ui.themeroller
milestone: TBD1.8
priority: majorcritical

Changed August 05, 2009 05:03PM UTC by jzaefferer comment:2

priority: criticalblocker

Changed February 10, 2010 04:27PM UTC by scottjehl comment:3

I've updated app.js to convert the hex to lowercase in the validHex function. I'm not sure how to push this live anymore with everything on static - in fact, I'm not sure how to even test that it works beforehand!

I will follow through with server-side fix as well.

Changed February 10, 2010 04:42PM UTC by scottjehl comment:4

Also updated parseVars.php with strtolower() wrapped around all incoming hex values.

Changed February 10, 2010 04:51PM UTC by scottjehl comment:5

resolution: → fixed
status: newclosed