Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#4609 closed bug (fixed)

Custom Theme Downloader does not change icon colors

Reported by: mawcs Owned by:
Priority: blocker Milestone: 1.8
Component: [meta] ui.downloadbuilder Version: 1.7.2
Keywords: Icon, color Cc: maw+jquery@…
Blocked by: Blocking:

Description

Built a custom theme, set all of the icon colors to: #0b7500 Downloaded custom theme. Opened Zip file and none of the icon files have the color #0b7500.

Change History (5)

comment:1 Changed 11 years ago by Jörn Zaefferer

Milestone: TBD1.8

comment:2 Changed 11 years ago by d3r1v3d

Seems to be an issue with downloading custom themes in Internet Explorer. Downloading custom themes in Firefox 3.5 and Chrome go without a hitch, but IE's distribution results in a gray-scale (i.e. non-themed) theme everytime. I'll check into this.

comment:3 Changed 11 years ago by Jörn Zaefferer

Priority: criticalblocker

Asked Gavin about the status.

comment:4 Changed 11 years ago by d3r1v3d

ThemeRoller sends theme-specific CSS using a GET request to the PHP page that encodes it. As this can be rather large, I believe this ticket results from an issue with IE's cap on query limit string sizes. Here are some numbers:

FireFox 2 = max of 8182 chars
Safari 2 = max of 8184 chars
IE 7.0 = max of 2047 chars

This seems a likely culprit as theming seems to work fine in FF, Chrome, etc - but not in IE.

I'll take a look into this problem sometime this weekend. Is there a projected date for 1.8 that everyone's pushing for?

  • Gavin

comment:5 Changed 10 years ago by rdworth

Resolution: fixed
Status: newclosed

Fixed with the 1.8rc1 update to download builder.

Note: See TracTickets for help on using tickets.