Opened 10 years ago

Closed 10 years ago

#4627 closed bug (fixed)

themeroller bookmarklet conflicts with page scripts

Reported by: scottjehl Owned by:
Priority: critical Milestone: 1.8
Component: [meta] ui.themeroller Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:

Description

The TR bookmarklet injects jQuery and UI when it loads, overriding any customizations done to jQuery already on the page. These need to run without conflicting with the page.

Change History (4)

comment:1 Changed 10 years ago by Jörn Zaefferer

Using $.noConflict is should be possible to load both jQuery and jQuery UI and still keep everything on the page intact. The pattern should be:

// store old references, maybe just "old = jQuery"?
var old = $.noConflict(true);
// load jQuery and jQuery UI, initialize themeroller
...
// restore old references
$ = jQuery = old;

comment:2 Changed 10 years ago by Jörn Zaefferer

Milestone: TBD1.8

comment:3 Changed 10 years ago by Scott González

Actually, you can load jQuery and jQuery UI, store a reference to jQuery, then call $.noConflict(true) and it'll restore the old references for you.

comment:4 Changed 10 years ago by mikehostetler

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.