#4654 closed enhancement (fixed)

Opened July 04, 2009 06:25AM UTC

Closed January 07, 2010 04:09AM UTC

Persistent Position & Size for dialogs

Reported by: burhan Owned by:
Priority: minor Milestone: 1.8
Component: ui.dialog Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:
Description

In the current release of dialog (1.7.2), when a dialog is created and re-positioned, then closed and opened again, the position is reset while the size is persistent.

This patch changes this behavior to use the new position when the dialog is opened again.

It also adds a new option, history, which when set is used as options to the cookie plugin, to store the position and size of the dialog to be used when a dialog is created on an element by the same id, to overwrite the default position and size. The dialog is identified by its id in the cookie. This will only function when the cookie plugin is present, and will not cause an error when it is missing.

Attachments (3)
  • ui.dialog.2.diff (2.3 KB) - added by burhan July 08, 2009 09:58AM UTC.

    The patch file

  • ui.dialog.diff (1.4 KB) - added by burhan July 08, 2009 09:57AM UTC.

    The patch file

  • ui.dialog.js (18.1 KB) - added by burhan July 08, 2009 09:20AM UTC.

    Patched ui.dialog file

Change History (4)

Changed July 04, 2009 09:47AM UTC by jzaefferer comment:1

Could you provide an actual patch, that is, a diff between your version and trunk?

Changed July 09, 2009 02:16PM UTC by jzaefferer comment:2

milestone: TBD → 1.8

Changed July 21, 2009 03:23AM UTC by scottgonzalez comment:3

Persistent positioning is being handled on its own in #4679.

Changed January 07, 2010 04:09AM UTC by scottgonzalez comment:4

resolution: → fixed
status: new → closed

Closing fixed since size and position are persistent. We shouldn't add cookie support until we have a plan to do that across the whole suite.