Opened 9 years ago

Closed 8 years ago

#4654 closed enhancement (fixed)

Persistent Position & Size for dialogs

Reported by: burhan Owned by:
Priority: minor Milestone: 1.8
Component: ui.dialog Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:

Description

In the current release of dialog (1.7.2), when a dialog is created and re-positioned, then closed and opened again, the position is reset while the size is persistent. This patch changes this behavior to use the new position when the dialog is opened again. It also adds a new option, history, which when set is used as options to the cookie plugin, to store the position and size of the dialog to be used when a dialog is created on an element by the same id, to overwrite the default position and size. The dialog is identified by its id in the cookie. This will only function when the cookie plugin is present, and will not cause an error when it is missing.

Attachments (3)

ui.dialog.js (18.1 KB) - added by burhan 9 years ago.
Patched ui.dialog file
ui.dialog.diff (1.4 KB) - added by burhan 9 years ago.
The patch file
ui.dialog.2.diff (2.3 KB) - added by burhan 9 years ago.
The patch file

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by Jörn Zaefferer

Could you provide an actual patch, that is, a diff between your version and trunk?

Changed 9 years ago by burhan

Attachment: ui.dialog.js added

Patched ui.dialog file

Changed 9 years ago by burhan

Attachment: ui.dialog.diff added

The patch file

Changed 9 years ago by burhan

Attachment: ui.dialog.2.diff added

The patch file

comment:2 Changed 9 years ago by Jörn Zaefferer

Milestone: TBD1.8

comment:3 Changed 9 years ago by Scott González

Persistent positioning is being handled on its own in #4679.

comment:4 Changed 8 years ago by Scott González

Resolution: fixed
Status: newclosed

Closing fixed since size and position are persistent. We shouldn't add cookie support until we have a plan to do that across the whole suite.

Note: See TracTickets for help on using tickets.