Skip to main content

Search and Top Navigation

#4751 closed bug (fixed)

Opened August 04, 2009 06:12PM UTC

Closed August 04, 2009 11:35PM UTC

Dragging slider modifies values, even if callback returns false

Reported by: bkrausz Owned by:
Priority: minor Milestone: 1.8
Component: ui.slider Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:

Line 347 of ui.slider.js:

                var newValues = this.values();
                newValues[index] = newVal;

actually modifies the value. This causes two problems:

1) One can't determine the old value inside the slide callbacks (for example, to determine if the slider is being dragged to the left or right).

2) Possibly the cause of bug #4385, since the value will be changed, and all further requests will be fail because of this.

Should probably change this to:

                var newValues = this.values().clone();
                newValues[index] = newVal;
Attachments (0)
Change History (1)

Changed August 04, 2009 11:35PM UTC by scottgonzalez comment:1

milestone: TBD1.8
resolution: → fixed
status: newclosed

Fixed in r3027. Thanks.