Skip to main content

Search and Top Navigation

#4800 closed bug (fixed)

Opened August 24, 2009 12:22PM UTC

Closed October 16, 2012 03:20PM UTC

Dialog: Modal UI Dialog stops links working if closed quickly

Reported by: rpcutts Owned by:
Priority: major Milestone: 1.7.2
Component: ui.dialog Version: 1.7.1
Keywords: modal Cc:
Blocked by: Blocking:
Description

If I call foo.dialog('open') to show a 'loading in progress' message but then foo.dialog('close') is fired in quick succession then any <a>

links on my page stop working unless I use right click > open link.

All inputs still work and if another dialog is shown and then closed after a delay then the links start working again.

Attachments (0)
Change History (9)

Changed August 24, 2009 12:34PM UTC by rpcutts comment:1

I have since created a simple test page to try and recreate the issue and am unable to do so at present. There must be something else involved in causing the problem.

Changed August 24, 2009 12:47PM UTC by rpcutts comment:2

It seems <a> links do catch the button click but don't redirect.

I have gotten around the problem by calling foo.dialog('close') on the click event of all <a> tags.

Changed August 27, 2009 03:52PM UTC by jdsharp comment:3

When the dialog is used in modal mode it binds a click event handler to the document. It appears that if your 'close' is firing before the dialog has fully loaded and the click event isn't unbound.

A work around would be to do $(document).unbind('.dialog-overlay');

Cheers,

  • Jonathan

Changed November 16, 2009 08:40PM UTC by jzaefferer comment:4

milestone: TBD1.8

Sounds like this can only be a problem by dialog using setTimeout somewhere.

Changed September 07, 2011 12:44PM UTC by scottgonzalez comment:5

keywords: modal dialog linksmodal

Changed October 11, 2012 02:47PM UTC by scottgonzalez comment:6

milestone: 1.9.01.10.0

Changed October 15, 2012 05:52PM UTC by petersendidit comment:7

status: newopen
summary: Modal UI Dialog stops links working if closed quicklyDialog: Modal UI Dialog stops links working if closed quickly

Changed October 16, 2012 03:08PM UTC by fontzter comment:8

I cannot replicate this bug. A test case that immediately chains a close to the creation of the dialog is here: http://jsfiddle.net/xwf7q/

On the creation of the overlay, there is a 1 millisecond setTimeout that binds the document events and returns false if they are below the z-index of the dialog. But it appears that is not causing a problem in the test case.

Changed October 16, 2012 03:20PM UTC by scottgonzalez comment:9

milestone: 1.10.01.7.2
resolution: → fixed
status: openclosed