Opened 10 years ago

Closed 9 years ago

Last modified 6 years ago

#4835 closed bug (worksforme)

IE8: load() together with ui.dialog creates full-hight dialog

Reported by: felix- Owned by:
Priority: minor Milestone:
Component: ui.dialog Version: 1.7.2
Keywords: height IE load Cc:
Blocked by: Blocking:

Description

on

.dialog({modal: true, height: 550, width: 600}).load('whatever.php');

and whatever.php delivers a value thats bigger than the height - IE ignores the height value

i could find a problem in this function

_size: function() {
		/* If the user has resized the dialog, the .ui-dialog and .ui-dialog-content
		 * divs will both have width and height set, so we need to reset them
		 */
		var options = this.options;

		// reset content sizing
		this.element.css({
			height: 0,
			minHeight: 0,
			width: 'auto'
		});

		// reset wrapper sizing
		// determine the height of all the non-content elements
		var nonContentHeight = this.uiDialog.css({
				height: 'auto',
				width: options.width
			})
			.height();
			
		this.element
			.css({
				minHeight: Math.max(options.minHeight - nonContentHeight, 0),
				height: options.height == 'auto'
					? 'auto'
					:  Math.max(options.height - nonContentHeight, 0)
			});
	}

in the variable nonContentHeight firefox throws for example 54 but ie delivers the maximum size of the browsers available height (for example 860) a quick and dirty fix for this is to enter

if ($.browser.msie) {nonContentHeight = 54;}

in the function. but i don't know how to fix this issue in a nice way

wish you a nice day :) felix

Change History (2)

comment:1 Changed 9 years ago by Scott González

Resolution: worksforme
Status: newclosed

This works properly for me. Please attach a test case if you continue to have problems.

comment:2 Changed 6 years ago by Scott González

Milestone: TBD

Milestone TBD deleted

Note: See TracTickets for help on using tickets.