window.location.reload() doesn't work in dialog's close callback when it's triggered by ESC in Firefox

[bohdan.ganicky]

code:

$('#dialog').dialog({
  close: function() {
    window.location.reload();
  }
});

expected behavior:

• when I press ESC on focused dialog, dialog is closed and page is reloaded
• when I click close (X) button on dialog's header, dialog is closed and page is reloaded

actual behavior:

• dialog is closed but page IS NOT reloaded when I press ESC in Firefox
• dialog is closed and page is reloaded properly when I click close (X) button on dialog's header

testcase:

​http://jsbin.com/aheyo

[jzaefferer]

There shouldn't be any difference, both the ESC-keyhandler and the x-icon-click-handler use the close-method, which triggers the close-event.

[bohdan.ganicky]

Exactly. It's weird but it's so. :(

[btburnett3]

My best guess is that Firefox is responding to the escape like you're hitting the stop button, which cancels the current load (or reload in this case). Fixed in r3839 by canceling the keydown event for the ESC key after it is handled.