Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#4983 closed bug (notabug)

font-family shouldn't be in the css generated

Reported by: marcandre Owned by:
Priority: minor Milestone: 1.10.0
Component: ui.core Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:

Description

I believe that I shouldn't see font-family anywhere in the CSS generated by jquery-ui. The font-family should be inherited from the whole site.

It appears twice (and I don't know why it appears the second time at all).

Thanks

Change History (5)

comment:1 Changed 12 years ago by Scott González

Resolution: invalid
Status: newclosed

This is configurable in themeroller. If you don't want those rules there, just delete them in the generated stylesheet.

comment:2 Changed 10 years ago by selfthinker

This is not really configurable in the ThemeRoller. When you remove the font-family, the CSS which gets produced includes an empty "font-family: ;", which is invalid.

Personally, I cannot think of a single scenario in which it would be desirable to include a font-family. It should be default behaviour to leave it out and only include it if added in the ThemeRoller.

Last edited 10 years ago by selfthinker (previous) (diff)

comment:3 Changed 9 years ago by Scott González

Milestone: TBD

Milestone TBD deleted

comment:4 Changed 9 years ago by selfthinker

I just found that you actually can "remove" the font-family in ThemeRoller, but not by deleting the value, but by swapping the font stack with "inherit".

comment:5 Changed 9 years ago by Scott González

Milestone: 1.10.0

Right after I closed this, I filed an issue to use inherit: https://github.com/jquery/download.jqueryui.com/issues/32 It looks like I forgot to cross-reference that issue from this ticket.

This was implemented a few days later: https://github.com/jquery/download.jqueryui.com/commit/0d7315e387cd75af542ab7068e5410832a76fff1

Go ahead and try deleting the font family in ThemeRoller, you'll get a theme that isn't broken :-)

Note: See TracTickets for help on using tickets.