Search and Top Navigation
#4983 closed bug (notabug)
Opened November 27, 2009 07:54PM UTC
Closed November 27, 2009 11:25PM UTC
Last modified November 28, 2012 03:50PM UTC
font-family shouldn't be in the css generated
| Reported by: | marcandre | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.10.0 |
| Component: | ui.core | Version: | 1.7.2 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
I believe that I shouldn't see font-family anywhere in the CSS generated by jquery-ui. The font-family should be inherited from the whole site.
It appears twice (and I don't know why it appears the second time at all).
Thanks
Attachments (0)
Change History (5)
Changed November 27, 2009 11:25PM UTC by comment:1
| resolution: | → invalid |
|---|---|
| status: | new → closed |
Changed November 05, 2011 11:21AM UTC by comment:2
| _comment0: | This is '''not really''' configurable in the !ThemeRoller. When you remove the font-family, the CSS which gets produced includes an empty "font-family: ;", which is invalid. \ \ Personally, I cannot think of a single scenario in which it would be desirable to include a font-family. It should be default behaviour to leave it out and only include it if added in the !ThemeRoller. → 1320492302221607 |
|---|
This is not really configurable in the ThemeRoller. When you remove the font-family, the CSS which gets produced includes an empty "font-family: ;", which is invalid.
Personally, I cannot think of a single scenario in which it would be desirable to include a font-family. It should be default behaviour to leave it out and only include it if added in the ThemeRoller.
Changed October 11, 2012 09:15PM UTC by comment:3
| milestone: | TBD |
|---|
Milestone TBD deleted
Changed November 28, 2012 12:32PM UTC by comment:4
I just found that you actually **can** "remove" the font-family in ThemeRoller, but not by deleting the value, but by swapping the font stack with "**inherit**".
Changed November 28, 2012 03:50PM UTC by comment:5
| milestone: | → 1.10.0 |
|---|
Right after I closed this, I filed an issue to use inherit: https://github.com/jquery/download.jqueryui.com/issues/32 It looks like I forgot to cross-reference that issue from this ticket.
This was implemented a few days later: https://github.com/jquery/download.jqueryui.com/commit/0d7315e387cd75af542ab7068e5410832a76fff1
Go ahead and try deleting the font family in ThemeRoller, you'll get a theme that isn't broken :-)
This is configurable in themeroller. If you don't want those rules there, just delete them in the generated stylesheet.