Opened 10 years ago
Closed 10 years ago
#5011 closed bug (fixed)
DatePicker Check External Click bug
| Reported by: | jeffgran | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.8 |
| Component: | ui.datepicker | Version: | 1.7.2 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
I found a bug where the date picker will sometimes close (because of an external click) even if you clicked within the date picker. I found a solution that fixed it for me.
In the datepicker's _checkExternalClick function, I changed the line:
if (($target.parents('#' + $.datepicker._mainDivId).length == 0) &&
to:
if (($target.parents().andSelf().filter('#' + $.datepicker._mainDivId).length == 0) &&
It was only checking if the click targets parents were the datepicker, not if you click directly on the date picker div itself.
Change History (2)
comment:1 Changed 10 years ago by
| Milestone: | TBD → 1.8 |
|---|
comment:2 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
This could probably use .closest().