Search and Top Navigation
#5065 closed bug (fixed)
Opened January 15, 2010 06:50PM UTC
Closed January 15, 2010 10:42PM UTC
Last modified January 18, 2012 01:44AM UTC
Broken AJAX tab links after jQuery 1.4
| Reported by: | jabbott7 | Owned by: | |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.7.3 |
| Component: | ui.tabs | Version: | 1.7.2 |
| Keywords: | 1.4-compat | Cc: | jason.abbott@tax.idaho.gov |
| Blocked by: | Blocking: |
Description
It seems I must be missing something obvious, but
All AJAX tabs now show the link as ...#ui-tabs-[object Object] rather than #ui-tabs-21 (or whatever number). This causes a mismatch exception to be thrown from jQuery when clicking the tab.
I made a test page (attached) where I can just change between 1.4/1.3.2 to fix or break it. Tried in IE8 and FF35.
Attachments (1)
Change History (6)
Changed January 15, 2010 07:15PM UTC by comment:1
Changed January 15, 2010 07:42PM UTC by comment:2
The workaround is fairly simple. UI 1.8 fixes it so I followed it's example for 1.7.2 and slipped var tabId=0 into the minified tabs function and replaced a.data(b) with (++tabId).
It looks like there might be a couple other spots in the cookies support that use the deprecated .data() call but I haven't activated cookie support. The fix would be similar, I imagine.
Changed January 15, 2010 10:42PM UTC by comment:3
| milestone: | TBD → 1.8 |
|---|---|
| resolution: | → fixed |
| status: | new → closed |
already fixed
Changed February 06, 2010 03:25AM UTC by comment:4
| keywords: | → 1.4-compat |
|---|
Changed March 29, 2010 02:20PM UTC by comment:5
Backported to 1.7.3 in r3976
Changed January 18, 2012 01:44AM UTC by comment:6
| milestone: | 1.8 → 1.7.3 |
|---|
It looks like line 42 of ui.tabs.js is probably the culprit.
given that $.data() has a breaking change. Still not sure how best to fix it.