_determineButtonType does not work if a label for checkbox/radiobutton is not yet attached to the document

[tomas]

Steps to reproduce:

$("body").appendItems(
  $('<div>')
    .append('<input type="checkbox" id="id1"><label for="id1">button1</label>')
    .buttonset()
);

This bug prevents simple building of complex DOM structures with buttons.

My suggestion is to replace the following line:

this.buttonElement = $( "[for=" + this.element.attr("id") + "]" );

with:

var selector = "[for=" + this.element.attr("id") + "]";
this.buttonElement = $( selector );
if (this.buttonElement.size() == 0)
  this.buttonElement = this.element.parent().last().find( selector );

Or some more efficient alternative:)

[Scott González]

The suggested fix isn't valid as it will only work in situations where the label happens to be the last element.

[tomas]

I am not sure whether I understand properly, but it works even if the label is not the last element:

$("body").appendItems(
  $('<div>')
    .append('<label for="id1">button1</label><input type="checkbox" id="id1">')
    .buttonset()
);

[Scott González]

Sorry, I saw the .parent() and misunderstood. I now realize you meant .parents() and I understand the logic you're using.

[Scott González]

Fixed in r3883.

[tomas]

I see, sorry for typo.

[chillaranand]

same problem occurs if input is inside label ​http://fiddle.jshell.net/t2jhL9ru/5/