#5284 closed bug (fixed)

Opened March 05, 2010 02:04AM UTC

Closed October 26, 2011 02:46PM UTC

Position: Smarter collision detection

Reported by: scottgonzalez Owned by:
Priority: major Milestone: 1.9.0
Component: ui.position Version: 1.8
Keywords: Cc:
Blocked by: Blocking:
Description

Collision detection needs to be smart enough to never make the situation worse. Flipping should only happen if more of the element will be visible after the flip. Fitting should only shift until the maximum possible amount of the element is visible.

Attachments (0)
Change History (8)

Changed March 21, 2010 03:58PM UTC by jzaefferer comment:1

version: 1.7.2 → 1.8

We should create a testpage with four inputs, each in one corner, and position a menu based on the autocomplete-default for each input. Then you actually have to shrink the browser window to test, as position always does collision-detection against window - there is no way to specify a container against which to test.

Changed March 21, 2010 06:53PM UTC by jzaefferer comment:2

Created a visual testcase for Position: http://github.com/jquery/jquery-ui/blob/304a45c159f168f2fabb0167e36f243d7a95bf1e/tests/visual/position/default.html

Changed July 30, 2010 09:39AM UTC by jzaefferer comment:3

Improved that testcase a bit further: http://github.com/jquery/jquery-ui/commit/3f45f5ccf93853e9f309cdb052dc47d88e393516

It shows quite nicely one of the problems we have: http://view.jqueryui.com/master/tests/visual/position/position.html

The three menus on the right should be with the right corner on the inputs right corner.

Also: Setting collision: "fit" makes that test much worse. The bottom menus will actually end up overlapping their inputs.

Changed July 30, 2010 10:07AM UTC by jzaefferer comment:4

milestone: 1.next → 1.9
type: enhancement → bug

Changed August 07, 2010 08:21PM UTC by bhollis comment:5

I fixed the problem with the "flip" collision that caused the menus on the right to not align correctly:

http://github.com/bhollis/jquery-ui/commit/22797e5f1fbd731123a23405d5fd26342cada739

That commit also fixes a problem in the demo when you set both positions to "right bottom" then try to drag the orange element towards the top of the screen: http://jqueryui.com/demos/position/default.html

Changed October 19, 2010 03:39PM UTC by scottgonzalez comment:6

priority: critical → major

Changed August 16, 2011 08:36PM UTC by jzaefferer comment:7

Landed in master, needs some more testing to verify it covers everything we want.

Changed October 26, 2011 02:46PM UTC by scottgonzalez comment:8

resolution: → fixed
status: new → closed