Skip to main content

Search and Top Navigation

#5301 closed feature (wontfix)

Opened March 05, 2010 11:44PM UTC

Closed November 20, 2012 06:28PM UTC

Dialog: Add a numeric string to dialog width option

Reported by: shadetyler Owned by:
Priority: minor Milestone: 1.10.0
Component: ui.dialog Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:

Please add a parseInt method to the numeric parameter of the width option in the dialog widget.

Attachments (0)
Change History (8)

Changed March 10, 2010 07:00PM UTC by scottgonzalez comment:1


Changed November 22, 2011 10:53AM UTC by M.Gaetan89 comment:2

Adding parseInt() will break width: 'auto' (which actually work).

Changed November 22, 2011 01:21PM UTC by scottgonzalez comment:3

Replying to [comment:2 M.Gaetan89]:

Adding parseInt() will break width: 'auto' (which actually work).

Width: "auto" is not supported. Even in the case of height, where "auto" is supported, it's very easy to not use parseInt() when the value is auto.

Changed October 03, 2012 05:01PM UTC by scottgonzalez comment:4

milestone: 1.next1.10.0

Changed October 15, 2012 07:29PM UTC by petersendidit comment:5

status: newopen
summary: Add a numeric string to dialog width optionDialog: Add a numeric string to dialog width option

Changed November 18, 2012 08:59PM UTC by jzaefferer comment:6

What this point, aka usecase, of this?

Changed November 20, 2012 06:22PM UTC by scottgonzalez comment:7

I've always been against this, but somehow Richard convinced us at the redesign meeting that we should allow this. I'm still for closing as wontfix, for the same reasons as always. The API is clear, passing "5" instead of 5 should have undefined behavior. Also, saying that we support a string means extra documentation that need to clearly explain that we don't support any units, because people will certainly start doing: height: "300px" and at some point we'll get a bug report that height: "10em" fails.

I asked mikesherov if there were any APIs in core that accepts strings but forced pixel values, and I don't think he came up with any. We should double check, but if that's the case, then I think we should close this.

Changed November 20, 2012 06:28PM UTC by scottgonzalez comment:8

resolution: → wontfix
status: openclosed

Confirmed. String values always respect units, and dialog only accepts pixels.