Skip to main content

Search and Top Navigation

#5305 closed bug (fixed)

Opened March 08, 2010 03:33PM UTC

Closed March 08, 2010 04:49PM UTC

Autocomplete: open event should trigger after the menu is opened since the name is not 'beforeopen'

Reported by: rdworth Owned by:
Priority: blocker Milestone: 1.8
Component: ui.autocomplete Version: 1.8rc3
Keywords: Cc:
Blocked by: Blocking:
Description

From http://forum.jquery.com/topic/alternating-style-on-autocomplete it was found that the autocomplete event open as implemented and documented in 1.8rc3 is inconsistent as the event triggers before the menu is opened, but it's called 'open' not 'beforeopen'.

As there's no current use case proposed for beforeopen, it is proposed to change the behavior of the 'open' event to be consistent with other open events. The event should trigger on/after open.

Attachments (0)
Change History (2)

Changed March 08, 2010 04:09PM UTC by rdworth comment:1

description: From http://forum.jquery.com/topic/alternating-style-on-autocomplete it was found that the autocomplete event open as implemented and documented in 1.8rc3 is inconsistent as the event triggers before the menu is opened, but it's called 'open' instead of 'beforeopen'. \ \ Fix: the existing event 'open' should be renamed to 'beforeopen' and a new event 'open' created that triggers after the menu is opened. This will be consistent with dialogbeforeclose and dialogclose, for example.From http://forum.jquery.com/topic/alternating-style-on-autocomplete it was found that the autocomplete event open as implemented and documented in 1.8rc3 is inconsistent as the event triggers before the menu is opened, but it's called 'open' not 'beforeopen'. \ \ As there's no current use case proposed for beforeopen, it is proposed to change the behavior of the 'open' event to be consistent with other open events. The event should trigger on/after open.
summary: Autocomplete: open event in 1.8rc3 should be renamed to beforeopen and a different open event createdAutocomplete: open event should trigger after the menu is opened since the name is not 'beforeopen'

Changed March 08, 2010 04:49PM UTC by rdworth comment:2

resolution: → fixed
status: newclosed

fixed in r3876