Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#5429 closed bug (notabug)

Incomplete event handling in UI TABS 1.8

Reported by: ollie2893 Owned by:
Priority: minor Milestone:
Component: ui.tabs Version: 1.8
Keywords: Cc:
Blocked by: Blocking:

Description

I believe that there is a "return false" missing from line #400 in jquery.ui.tabs.js (V1.8) like so

			// Prevent IE from keeping other link focussed when using the back button
			// and remove dotted border from clicked link. This is controlled via CSS
			// in modern browsers; blur() removes focus from address bar in Firefox
			// which can become a usability and annoying problem with tabs('rotate').
			if ($.browser.msie) {
				this.blur();
			}
			return false;
		});

This is the very bottom of the o.event handler after it has responded to an o.event on one of the tabs. Not returning false means that the event will bubble up the DOM. I have an event handler sweeping up unprocessed mouse events at the $(document) level (to blur widgets that have lost focus) and I catch these event bubbles. (As a result, I end up blurring objects that one milli-second earlier have only just been put into focus).

Change History (2)

comment:1 Changed 9 years ago by Scott González

Resolution: invalid
Status: newclosed

It's a bad idea to stop propagation of events, especially in generic plugins.

comment:2 Changed 7 years ago by Scott González

Milestone: TBD

Milestone TBD deleted

Note: See TracTickets for help on using tickets.