Skip to main content

Search and Top Navigation

#5429 closed bug (notabug)

Opened March 25, 2010 09:11PM UTC

Closed October 22, 2010 11:58PM UTC

Last modified October 11, 2012 09:15PM UTC

Incomplete event handling in UI TABS 1.8

Reported by: ollie2893 Owned by:
Priority: minor Milestone:
Component: ui.tabs Version: 1.8
Keywords: Cc:
Blocked by: Blocking:

I believe that there is a "return false" missing from line #400 in jquery.ui.tabs.js (V1.8) like so

			// Prevent IE from keeping other link focussed when using the back button
			// and remove dotted border from clicked link. This is controlled via CSS
			// in modern browsers; blur() removes focus from address bar in Firefox
			// which can become a usability and annoying problem with tabs('rotate').
			if ($.browser.msie) {
			return false;

This is the very bottom of the o.event handler after it has responded to an o.event on one of the tabs. Not returning false means that the event will bubble up the DOM. I have an event handler sweeping up unprocessed mouse events at the $(document) level (to blur widgets that have lost focus) and I catch these event bubbles. (As a result, I end up blurring objects that one milli-second earlier have only just been put into focus).

Attachments (0)
Change History (2)

Changed October 22, 2010 11:58PM UTC by scottgonzalez comment:1

resolution: → invalid
status: newclosed

It's a bad idea to stop propagation of events, especially in generic plugins.

Changed October 11, 2012 09:15PM UTC by scottgonzalez comment:2

milestone: TBD

Milestone TBD deleted