Opened 13 years ago
Closed 13 years ago
#5735 closed bug (fixed)
Dialog height not taking in IE8 when Prototype is used
| Reported by: | woakesd | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 1.8.5 |
| Component: | ui.dialog | Version: | 1.8.2 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
The following code demonstrates the problem, try it without Prototype and the page looks fine with a nice dialog, with Prototype the dialog height is reduced substantially.
Could be a Prototype bug of course!
This is a showstopper upgrading a client's site to 1.8.2. :(
<!DOCTYPE html PUBLIC "-W3CDTD XHTML 1.0 TransitionalEN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" > <head> <title></title> <link rel="stylesheet" type="text/css" href="http://ajax.googleapis.com/ajax/libs/jqueryui/1.8/themes/base/jquery-ui.css" /> <script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/prototype/1.6.1/prototype.js"></script> <script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> <script type="text/javascript"> jQuery.noConflict(); </script> <script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.2/jquery-ui.min.js"></script> <script type="text/javascript">
jQuery(function() {
var setupDialog = function(eltId) {
jQuery('<h1>hello world!</h1>').dialog({
autoOpen: true, width: 610, height: 450, modal: true, resizable: false, draggable: false
});
}; setupDialog();
});
</script> </head> <body>
</body> </html>
Change History (2)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
| Milestone: | TBD → 1.8.5 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
The underlying problem is actually in jQuery core and was recently fixed. The fix will go out with jQuery 1.4.3, at which point you should be able to use 1.7.3 or any 1.8.x release and the height should be correct.
I've subsequently discovered that this is also a problem with jQueryui 1.7.3 only when using jQuery 1.4.2 and Prototype 1.6.1.
If you use jQueryui 1.7.3 with jQuery 1.3.2 and Prototype 1.6.1 and dialog is the height you would expect.