Skip to main content

Search and Top Navigation

#5766 closed bug (fixed)

Opened June 24, 2010 05:32AM UTC

Closed September 03, 2010 02:43PM UTC

Last modified November 19, 2010 06:26PM UTC

position: collision should take margin into account

Reported by: bhollis Owned by:
Priority: major Milestone: 1.8.5
Component: ui.position Version: 1.8.2
Keywords: Cc:
Blocked by: Blocking:

The position utility should take into account margins when performing collisions (or offer some other way of offsetting the collision box from the element itself). This way you could prevent positioned elements from getting too close to the edge of the screen. This is especially useful when the positioned element uses -moz-box-shadow, since a shadow that falls outside the page will cause scrollbars.

Attachments (0)
Change History (8)

Changed June 24, 2010 06:15AM UTC by bhollis comment:1

Changed July 17, 2010 12:42AM UTC by bhollis comment:2

I'd really love to see this patch committed - without it there's no good way to use drop shadows on positioned elements or pop stuff up that doesn't go to the exact edge of the screen.

Changed July 30, 2010 10:05AM UTC by jzaefferer comment:3

milestone: TBD1.9
priority: minormajor
type: enhancementbug

Tested that commit. Testsuite fails on IE8.

Changed August 01, 2010 09:07PM UTC by bhollis comment:4

Changed August 13, 2010 05:40AM UTC by bhollis comment:5

I rebased the IE8 fix and the original patch together into one commit on top of the latest master if that makes it easier to pull:

Changed September 03, 2010 02:43PM UTC by scottgonzalez comment:6

resolution: → fixed
status: newclosed

Fixed in 4b9d5d1. Thanks bhollis.

Changed September 10, 2010 05:25PM UTC by scottgonzalez comment:7


Changed November 19, 2010 06:26PM UTC by Ben Hollis comment:8

Position: Take margin into account when performing collisions. Fixes #5766 - position: collision should take margin into account.

Changeset: 4b9d5d1b5bd36726c6e49b105c0f75649cca1ae4