Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#5833 closed bug (notabug)

Introduction of by-href functionality broke collapsible tabs functionality

Reported by: brazilianjoe Owned by:
Priority: major Milestone:
Component: ui.tabs Version: 1.8.2
Keywords: Cc:
Blocked by: Blocking:

Description

The patch which introduced option to operate tabs by href broke the functionality of collapsing all tabs.

Additionaly, a leftover 'else' is giving a syntax error.

A patch is already in the works.

Change History (3)

comment:1 Changed 9 years ago by brazilianjoe

Patch in git, pull requested already:

http://github.com/BrazilianJoe/jquery-ui/commit/d3647e42feab0609047d45a8ae30a309953e6ae0

This patch restores collapsing all tabs. This will work with either: $('#tabs').tabs('select',NaN); or $('#tabs').tabs('select');

if the option collapsible is true.

Documentation should be updated accordingly, but I have no idea how to do that.

comment:2 Changed 9 years ago by Scott González

Resolution: invalid
Status: newclosed

This was never released.

comment:3 Changed 7 years ago by Scott González

Milestone: TBD

Milestone TBD deleted

Note: See TracTickets for help on using tickets.