Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#5857 closed bug (duplicate)

Tabs should use context when searching for panels

Reported by: petersendidit Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.tabs Version: 1.8.2
Keywords: Cc:
Blocked by: Blocking:


If a tabs href is a valid hash then tries to push that panel in to the panels array. This works great if the tabs are already in the document but if they are in a documentFragment then this fails.

The fix is easy. Just change this line in the _tabify function

self.panels = self.panels.add(self._sanitizeSelector(href));


self.panels = self.panels.add(self._sanitizeSelector(href), self.element);

Now it will handle the tabs not being part of the document yet.

Change History (5)

comment:2 Changed 6 years ago by scottgonzalez

  • Component changed from ui.core to ui.tabs
  • Keywords tabs removed

comment:3 Changed 6 years ago by waldmang

Same apply also to the $show element: $show = $(self._sanitizeSelector(this.hash));

should be

$show = $(self._sanitizeSelector(this.hash),self.element);

comment:4 Changed 6 years ago by scottgonzalez

  • Resolution set to duplicate
  • Status changed from new to closed

comment:5 Changed 6 years ago by scottgonzalez

Duplicate of #6710.

Note: See TracTickets for help on using tickets.