Skip to main content

Search and Top Navigation

#5857 closed bug (duplicate)

Opened July 23, 2010 06:03PM UTC

Closed December 20, 2010 01:42PM UTC

Last modified December 20, 2010 01:42PM UTC

Tabs should use context when searching for panels

Reported by: petersendidit Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.tabs Version: 1.8.2
Keywords: Cc:
Blocked by: Blocking:

If a tabs href is a valid hash then tries to push that panel in to the panels array. This works great if the tabs are already in the document but if they are in a documentFragment then this fails.

The fix is easy. Just change this line in the _tabify function

self.panels = self.panels.add(self._sanitizeSelector(href));


self.panels = self.panels.add(self._sanitizeSelector(href), self.element);

Now it will handle the tabs not being part of the document yet.

Attachments (0)
Change History (5)

Changed July 23, 2010 06:04PM UTC by petersendidit comment:1

Changed July 23, 2010 06:24PM UTC by scottgonzalez comment:2

component: ui.coreui.tabs
keywords: tabs

Changed July 26, 2010 03:46PM UTC by waldmang comment:3

Same apply also to the $show element:

$show = $(self._sanitizeSelector(this.hash));

should be

$show = $(self._sanitizeSelector(this.hash),self.element);

Changed December 20, 2010 01:42PM UTC by scottgonzalez comment:4

resolution: → duplicate
status: newclosed

Changed December 20, 2010 01:42PM UTC by scottgonzalez comment:5

Duplicate of #6710.