Skip to main content

Search and Top Navigation

#6038 closed enhancement (fixed)

Opened September 09, 2010 02:30PM UTC

Closed September 27, 2010 02:13PM UTC

Last modified November 19, 2010 06:26PM UTC

Autocomplete: Allow default behaviour on enter when menu is open but inactive

Reported by: jzaefferer Owned by:
Priority: major Milestone: 1.8.6
Component: ui.autocomplete Version: 1.8.4
Keywords: Cc:
Blocked by: Blocking:
Description

To reproduce: Type something to open the autocomplete, then hit enter, without selecting something. The default behaviour, eg. submitting a search form should happen. Instead the default behaviour is prevented.

Attachments (0)
Change History (6)

Changed September 21, 2010 10:04AM UTC by bjoernhaeuser@gmail.com comment:1

Hello!

First i want to thank you for this great plugin. I really love it and its very comfortable to use.

The only thing which bothers me is this enhancement (dont want to call it bug). Is there any fixe available?

Best regards!

Changed September 22, 2010 12:58AM UTC by roncli comment:2

Confirmed a bug in version 1.8.5. I was previously using version 1.8.2 when it was last working correctly.

I worked around this by removing the following from jquery-ui-1.8.5.min.js:

 case d.ENTER:case d.NUMPAD_ENTER:a.menu.element.is(":visible")&&c.preventDefault(); 

Changed September 22, 2010 01:51AM UTC by scottgonzalez comment:3

Replying to [comment:2 roncli]:

Confirmed a bug in version 1.8.5. I was previously using version 1.8.2 when it was last working correctly.

Note that this is not a bug. The current behavior is intentional but we're planning on changing it.

Changed September 27, 2010 02:13PM UTC by scottgonzalez comment:4

resolution: → fixed
status: newclosed

Fixed in adcafce.

Changed October 25, 2010 06:53PM UTC by scottgonzalez comment:5

milestone: 1.91.8.6

Changed November 19, 2010 06:26PM UTC by Scott González comment:6

Autocomplete: Only prevent the default action for enter when a menu item is active. Fixes #6038 - Autocomplete: Allow default behaviour on enter when menu is open but inactive.

Thanks Ján Suchal.

Changeset: adcafce7a24156c503061eb354867e41064fd89f