ui.dialog & resizable & button & opera 11

[demimurych]

Run opera 11 Go to ​http://jqueryui.com/demos/dialog/#modal-message

Try to resize dilog box

Look at button pane

[levu]

I have a screencast for this bug: ​https://scienceco.de/~levu/dialog_opera_button.ogv

[tj.vantoll]

Created a minimal test case - ​http://jsfiddle.net/aKxgY/2/.

[Mamen]

Masking Opera as Firefox fixes this. This means that custom code is executed for Opera. I'm guessing this code in ui.resizable is responsible:

//Opera fix for relative positioning
if (/relative/.test(this.element.css('position')) && $.browser.opera)
	this.element.css({ position: 'relative', top: 'auto', left: 'auto' });

[tj.vantoll]

This is the code that specifically creates the issue (in _alsoResize within resize):

// Opera fixing relative position
if ($.browser.opera && /relative/.test(el.css('position'))) {
    self._revertToRelativePosition = true;
    el.css({ position: 'absolute', top: 'auto', left: 'auto' });
}

In this instance it sets the .ui-dialog-content div to position: absolute which causes the layout issue. If that block is commented out this issue is fixed.

I'm wondering if anyone knows what the original hack for Opera was fixing? The only reference in the bug tracker to this I can find are ​#5694 & ​#5695 which are both fixes to the hack, and don't really explain what the hack was originally for. It appears to have been in there since the beginning of Git time and there aren't any unit tests for it.

If I remove the Opera hacks in their entirety all the demos work fine at least. Maybe this is a bug that Opera has fixed...?

[Scott González]

Thanks tj. I'm not sure what it was fixing either. Now that we only support Opera 11.5+, it should be safe to remove. Can you send a pull request?

[tj.vantoll]

Pull request - ​https://github.com/jquery/jquery-ui/pull/593

[Scott González]

Fixed in f5e5971821dab4caf03dae4a6d207429aef44bae.

[Scott González]

Fixed in 1-8-stable in 28fb436b7b75de01cc1caf3132f56381b6c7c190.