Dialog box button iteration bug

[SlappyZA]

I have stumbled on a edge case where by if the Array prototype has been extended, then when creating buttons using the button array for the modal dialog box, the function names of the extended prototype appear as buttons too. I suspect this is due to iterating over the button array using associative array loops instead of counter loops.

Steps to reproduce:

1: Create a function that extends the array prototype:

Array.prototype.someFunction = function () {}

2: Create a dialog:

$('#element').dialog({
            modal: true,
            buttons: [
                { text: 'Select', click: function(){} },
                { text: 'Cancel', click: function() {} }
            ]
        });

Expected Result: There will be three buttons on the dialog: Select, Cancel and someFunction

[Scott González]

We don't support modifying native prototypes.