#6789 closed enhancement (wontfix)

Opened December 29, 2010 12:26PM UTC

Closed May 05, 2011 12:11PM UTC

DatePicker _selectDate doesn't have to use $(id)

Reported by: Debbus Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.datepicker Version: 1.8.4
Keywords: Cc:
Blocked by: Blocking:
Description

In DatePicker in the function '_selectDay' and '_selectDate' (there are more) the first thing what is done, is that via $(id) a target is retrieved from the DOM.

      _selectDay: function (id, month, year, td) {
         var target = $(id);

However, you shouldn't have to do this, because the current instance is known. 

      _selectDay: function (id, month, year, td) {
         var target = this._curInst.input;
Attachments (0)
Change History (2)

Changed May 05, 2011 09:46AM UTC by utkarsh comment:1

This change breaks 5 unit tests on DatePicker (All involving inline date picker + mouse).

Changed May 05, 2011 12:11PM UTC by scottgonzalez comment:2

resolution: → wontfix
status: new → closed

Datepicker is going to be rewritten. The rewrite will follow our normal coding standards and use the widget factory, which will avoid this problem.