Opened 9 years ago

Closed 9 years ago

#6789 closed enhancement (wontfix)

DatePicker _selectDate doesn't have to use $(id)

Reported by: Debbus Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.datepicker Version: 1.8.4
Keywords: Cc:
Blocked by: Blocking:

Description

In DatePicker in the function '_selectDay' and '_selectDate' (there are more) the first thing what is done, is that via $(id) a target is retrieved from the DOM.

      _selectDay: function (id, month, year, td) {
         var target = $(id);

However, you shouldn't have to do this, because the current instance is known.

      _selectDay: function (id, month, year, td) {
         var target = this._curInst.input;

Change History (2)

comment:1 Changed 9 years ago by utkarsh

This change breaks 5 unit tests on DatePicker (All involving inline date picker + mouse).

comment:2 Changed 9 years ago by Scott González

Resolution: wontfix
Status: newclosed

Datepicker is going to be rewritten. The rewrite will follow our normal coding standards and use the widget factory, which will avoid this problem.

Note: See TracTickets for help on using tickets.