appendText wrongly follows isRTL

[aneves]

​datepicker#appendText
​datepicker#isRTL

In a nutshell

dir="rtl" on HTML + isRTL: true, appendText: "dd/mm/yyyy on datepicker = appendText before input.
(Before is on the right, for RTL.)

example: ​http://jsfiddle.net/hhuvT/1/

The same seems to happen if direction is set using CSS.

A solution would be to simply output the appendText afterwards.
But that might frustrate existing assumptions of behaviour.

Context

I work developing a multilingual website, user picks his language and everything is translated. When user selects arabic, I define in my HTML's opening tag the property dir="rtl". This makes content flow properly from right to left.

Problem

I define isRTL :true for my datepickers when language is arabic, most content flows from right to left properly. However the appendText content is writen to the page before the input. Because both the text and the input are inline, the dir="rtl" set on the page makes the appendText appear before the input and not after as intended. (For arabic, before is on the right.)

Solution?

​https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.datepicker.js#L206

That's the culprit.

I think setting dir="rtl" on the parent of the datepicker would potentially have side-effects, since that parent isn't generated by the datepicker... so I guess the thing to do is to just output the appendText afterwards and let the HTML dir="xyz" rule the relative position of the inline elements.
No?

[mikesherov]

This is confirmed.

These lines should always use after and nextSibling and let dir="rtl" take care of it, like the rest of the code does: ​https://github.com/jquery/jquery-ui/blob/a3f1a34d3b997550a5a8cf4c630e6580cd37cde5/ui/jquery.ui.datepicker.js#L216 ​https://github.com/jquery/jquery-ui/blob/a3f1a34d3b997550a5a8cf4c630e6580cd37cde5/ui/jquery.ui.datepicker.js#L233 ​https://github.com/jquery/jquery-ui/blob/a3f1a34d3b997550a5a8cf4c630e6580cd37cde5/ui/jquery.ui.datepicker.js#L787

[Scott González]

See also #7128