Opened 9 years ago

Closed 7 years ago

#6974 closed bug (fixed)

class animation: document what happens with properties that can't be animated

Reported by: thomsbg Owned by:
Priority: minor Milestone: 1.9.0
Component: [meta] ui.docs Version: 1.8.9
Keywords: Cc:
Blocked by: Blocking:

Description

Because the animation function is not able to animate some properties (like background-image), an elements appearance may suddenly change at the end of the class animation because that is when the target classes are finally applied.

This feature adds an boolean flag option that allows the target class to be applied at the beginning, so that the non-animatable effects of the changed className are visible during the animation.

Change History (6)

comment:2 Changed 9 years ago by danheberden

Resolution: wontfix
Status: newclosed

Great job on your alterations - that should help people stumbling across this bug report understand what's happening when their images suddenly update.

There is, though, some ambiguity in this topic. No matter what you do, the image is going to suddenly change. Fading an image from one to another, as I'm sure you've done, is an entirely different process all together.

While I can totally see why this feature would be helpful for you in your application, I don't think it has a place in jQuery UI. It's a chunk of code that still presents the same core problem: the style can't be animated.

But, because you've posted your fix, others who have an application specific need for this can benefit, so again: thank you.

comment:3 Changed 9 years ago by thomsbg

I decided to contribute this piece of code only because the decision of when to update the styles that can't be animated is somewhat arbitrary and not all that well documented. If only there were a commenting feature on the jQuery UI site like there is for jQuery, I would happier leaving this discussion there.

Last edited 9 years ago by thomsbg (previous) (diff)

comment:4 Changed 9 years ago by ajpiano

Component: effects.core[meta] ui.docs
Resolution: wontfix
Status: closedreopened
Type: featurebug

comment:5 Changed 9 years ago by Scott González

Summary: class animation: new option for when to apply non-animatable stylesclass animation: document what happens with properties that can't be animated

comment:6 Changed 7 years ago by Scott González

Resolution: fixed
Status: reopenedclosed

I've added a note in the new API repo.

Note: See TracTickets for help on using tickets.