Skip to main content

Search and Top Navigation

#7057 closed enhancement (fixed)

Opened March 03, 2011 01:54PM UTC

Closed March 03, 2011 02:39PM UTC

Last modified March 16, 2011 12:53PM UTC

An extra class is needed on the dialog wrapper to specify when a buttonset is showing

Reported by: dougneiner Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.dialog Version: 1.8.10
Keywords: Cc:
Blocked by: Blocking:
Description

As I started developing a new theme, I found out that there is no way of knowing (in just CSS) that a dialog has buttons. I think it is reasonable to assume people may want to style the content region of a dialog differently if there are buttons below it.

I propose adding a "ui-dialog-buttons" class to the .ui-dialog element when buttons are present. (Thanks Scott & Rich for the right name there!)

Attachments (0)
Change History (3)

Changed March 03, 2011 02:04PM UTC by dougneiner comment:1

milestone: 1.91.8.11
version: 1.8.91.8.10

Changed March 03, 2011 02:39PM UTC by Douglas Neiner comment:2

resolution: → fixed
status: newclosed

Dialog: Added a class to dialog wrapper when it is currently displaying buttons, includes unit tests for changes. Fixed #7057 - An extra class is needed on the dialog wrapper to specify when a buttonset is showing

Changeset: 15c97e0b76b4576d0c7bee9d54dc4662c23502b9

Changed March 16, 2011 12:53PM UTC by scottgonzalez comment:3

milestone: 1.8.111.9