Search and Top Navigation
#7111 closed feature (wontfix)
Opened March 14, 2011 03:02PM UTC
Closed March 14, 2011 06:49PM UTC
Dialog Close button has no title.
| Reported by: | David.Sullivan | Owned by: | David.Sullivan |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.9.0 |
| Component: | ui.dialog | Version: | 1.8.10 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
When the ui.dialog window opens the close button has no title.
Here is the HTML created by a dialog using the demo page. http://jqueryui.com/demos/dialog/.
<a href="#" class="ui-dialog-titlebar-close ui-corner-all" role="button">
<span class="ui-icon ui-icon-closethick">close</span>
</a>
This can be fixed by editing line # 138 of jquery.ui.dialog.js
It currently reads
.attr('role', 'button')
simply change it to
.attr({'role': 'button', 'title': options.closeText)
While not a major issue this could be considered a section 501b issue.
Attachments (0)
Change History (5)
Changed March 14, 2011 03:22PM UTC by comment:1
| owner: | → David.Sullivan |
|---|---|
| status: | new → pending |
Changed March 14, 2011 03:22PM UTC by comment:2
| component: | ui.core → ui.dialog |
|---|
Changed March 14, 2011 04:44PM UTC by comment:3
| status: | pending → new |
|---|
Yes I meant 508. Not all people that are disabled are blind. I categorize some stupid people disabled. People too stupid to realize what an X means without a tool tip. And yes I have had this come up in a production environment.
Changed March 14, 2011 06:43PM UTC by comment:4
There has been a tooltip-less "X" button in Windows since approximately the dawn of time, and people have figured it out - also conflating stupidity and disability is kind of... offensive.
Changed March 14, 2011 06:49PM UTC by comment:5
| resolution: | → wontfix |
|---|---|
| status: | new → closed |
| type: | bug → feature |
Agreed, there's no tooltip for close buttons in OS X either. This could easily be built as an extension and I'd prefer not to have jQuery UI create widgets that default to having unnecessary tooltips.
Do you mean section 508? Anyway, how is this a concern? The element contains text.