Opened 12 years ago

Closed 12 years ago

#7111 closed feature (wontfix)

Dialog Close button has no title.

Reported by: David.Sullivan Owned by: David.Sullivan
Priority: minor Milestone: 1.9.0
Component: ui.dialog Version: 1.8.10
Keywords: Cc:
Blocked by: Blocking:


When the ui.dialog window opens the close button has no title.

Here is the HTML created by a dialog using the demo page. <a href="#" class="ui-dialog-titlebar-close ui-corner-all" role="button">

<span class="ui-icon ui-icon-closethick">close</span>


This can be fixed by editing line # 138 of jquery.ui.dialog.js It currently reads

.attr('role', 'button')

simply change it to

.attr({'role': 'button', 'title': options.closeText)

While not a major issue this could be considered a section 501b issue.

Change History (5)

comment:1 Changed 12 years ago by Scott González

Owner: set to David.Sullivan
Status: newpending

Do you mean section 508? Anyway, how is this a concern? The element contains text.

comment:2 Changed 12 years ago by Scott González

Component: ui.coreui.dialog

comment:3 Changed 12 years ago by David.Sullivan

Status: pendingnew

Yes I meant 508. Not all people that are disabled are blind. I categorize some stupid people disabled. People too stupid to realize what an X means without a tool tip. And yes I have had this come up in a production environment.

comment:4 Changed 12 years ago by ajpiano

There has been a tooltip-less "X" button in Windows since approximately the dawn of time, and people have figured it out - also conflating stupidity and disability is kind of... offensive.

comment:5 Changed 12 years ago by Scott González

Resolution: wontfix
Status: newclosed
Type: bugfeature

Agreed, there's no tooltip for close buttons in OS X either. This could easily be built as an extension and I'd prefer not to have jQuery UI create widgets that default to having unnecessary tooltips.

Note: See TracTickets for help on using tickets.