Opened 6 years ago

Closed 4 years ago

#7186 closed bug (fixed)

addClass seems to trigger Invalid argument in IE in jquery 1.5.1

Reported by: bluefox Owned by: gnarf
Priority: major Milestone: 1.8.11
Component: ui.effects.core Version: 1.8.11
Keywords: Cc:
Blocked by: Blocking:

Description

Can be reproduced by going to ​http://jqueryui.com/demos/addClass/ with IE (8.0.7600.16385) and click Run Effect. A script error is generated

Invalid argument. jquery.min.js, line 16 character 79183

Might be a conflict with jQuery 1.5.1?

Change History (6)

comment:1 Changed 6 years ago by scottgonzalez

  • Priority changed from minor to major
  • Status changed from new to open

This is caused by a change in 1.5.1: ​https://github.com/jquery/jquery/commit/85d9343271da85fc945bf37a604873eaf247a3a7

comment:2 Changed 6 years ago by scottgonzalez

jQuery core bug: ​http://bugs.jquery.com/ticket/8627

comment:3 Changed 5 years ago by gnarf

  • Owner set to gnarf
  • Status changed from open to assigned

comment:4 Changed 5 years ago by gnarf

In the meantime, while waiting for jQuery Core to catch up to this bug, you can use this cssHook to fix this error: 

$.cssHooks.letterSpacing = {
    get: function ( elem, computed ) {
        var ret = parseFloat( elem.style.letterSpacing ) || 0;
        return ret;
    }
};

​http://jsfiddle.net/gnarf/bkd4S/3/

comment:5 Changed 4 years ago by scottgonzalez

gnarf: Any reason not to just land that cssHook in UI core? If $.cssHooks exists, define it, if not, don't do anything. That should handle all versions, right? We can land that in master and merge into 1-8-stable.

comment:6 Changed 4 years ago by scottgonzalez

  • Milestone changed from 1.9.0 to 1.8.11
  • Resolution set to fixed
  • Status changed from assigned to closed

This is fixed in jQuery core.

Note: See TracTickets for help on using tickets.